Skip to content

Restructured Codebase ,with minor utility fixes. #14

Open
Urten wants to merge 9 commits intoTheDauntless:devfrom
Urten:master
Open

Restructured Codebase ,with minor utility fixes. #14
Urten wants to merge 9 commits intoTheDauntless:devfrom
Urten:master

Conversation

@Urten
Copy link

@Urten Urten commented Oct 26, 2025

  1. Folder structure was added to README_PROJECT_LAYOUT.md
  2. added setup.py file for easy installation.
  3. major tools are added in a class based manner in the core directory.
  4. utility tools are added in a function based manner in the utils directory.

Utility changes -

  1. added --only-main-classes while rebuilding to avoid duplicate class error.

@TheDauntless
Copy link
Owner

It looks like you restructered based off of main, rather than from the dev branch I pushed a few days ago. The dev branch no longer uses objection to inject or sign and it already has some initial classes.

Apart from that, after a cursory look:

  • The .gitignore contains a bunch of irrelevant exceptions
  • The utils folder now contains a bunch of split up functions. What's the point of that and why is it better than having them in one place like the original code? It would make sense to refactor them into their own class (e.g. SplitAPKFixer), but just moving them into separate files seems unnecessary.

@Urten
Copy link
Author

Urten commented Oct 28, 2025

Ah I misunderstood your earlier comment. I never checked the dev branch. My bad.

  1. For the .gitignore, that's auto-generated and its a default template for python projects, it will be helpful for future contributions in case the code scales.

  2. I split the functions for better maintainability and readability. I think it would be easier to modify particular functions based on file names and other devs would get a better overview of the project workings. Horizontal scaling helps in the long run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants