Skip to content

Updating tests #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jpruiz114 merged 1 commit into from
Aug 24, 2025
Merged

Updating tests #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .phpunit.result.cache
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"version":2,"defects":{"PrimeNumberTest::testIsPrime":8,"PrimeNumberTest::testModPow":8,"PrimeNumberTest::testLargePrimeNumbers":8,"PrimeNumberTest::testEdgeCases":8,"IntegerTest::testIntegerValidations":7,"IntegerTest::testDivisionByBiggerDivisorException":7,"PrimeGeneratorTest::testGeneratePrime":7,"PrimeGeneratorTest::testPrimeGenerationPerformance":8,"PrimeGeneratorTest::testLargePrimeGeneration":8,"PrimalityComparisonTest::testSmallNumberComparison":7},"times":{"IntegerTest::testIntegerValidations":0.002,"IntegerTest::testInvalidNumberException":0,"IntegerTest::testCreateDefault":0,"IntegerTest::testCreateByInt":0,"IntegerTest::testCreateByString":0,"IntegerTest::testPrint":0,"IntegerTest::testAdd":0.082,"IntegerTest::testLargeAddition":0,"IntegerTest::testSubtract":0.082,"IntegerTest::testLargeSubtraction":0,"IntegerTest::testNegativeSubtraction":0,"IntegerTest::testSubtractWithNegativeResults":0.176,"IntegerTest::testLargeNegativeSubtraction":0,"IntegerTest::testMultiplyByInt":0,"IntegerTest::testMultiplyByIntException":0,"IntegerTest::testMultiply":0.397,"IntegerTest::testGreaterThan":0.048,"IntegerTest::testGreaterOrEqualTo":0,"IntegerTest::testStringLength":14.207,"IntegerTest::testMaximumMultiplier":0.026,"IntegerTest::testMaxMultiplierException":0,"IntegerTest::testNumberLength":0,"IntegerTest::testDivision":0.002,"IntegerTest::testDivisionByZeroException":0,"IntegerTest::testDivisionByBiggerDivisorException":0,"IntegerTest::testSeveralDivisions":0.064,"IntegerTest::testModule":0,"IntegerTest::testCreatingLargeNumber":0.001,"PrimeNumberTest::testIsPrime":0.015,"PrimeNumberTest::testIsProbablePrime":0,"PrimeNumberTest::testModPow":0,"PrimeNumberTest::testGcd":0,"PrimeNumberTest::testLcm":0.001,"PrimeNumberTest::testLargePrimeNumbers":0.184,"PrimeNumberTest::testEdgeCases":0,"PrimeGeneratorTest::testGenerateRandomOdd":0,"PrimeGeneratorTest::testGeneratePrime":0.476,"PrimeGeneratorTest::testGeneratePrimeSmallBits":0.012,"PrimeGeneratorTest::testGenerateTwinPrimes":0.273,"PrimeGeneratorTest::testGenerateNextPrime":0.007,"PrimeGeneratorTest::testGeneratePrimesInRange":0.033,"PrimeGeneratorTest::testGenerateRandomPrimeInRange":0.012,"PrimeGeneratorTest::testGenerateSophieGermainPrime":0.197,"PrimeGeneratorTest::testInvalidBitLength":0,"PrimeGeneratorTest::testInvalidBitLengthRandomOdd":0,"PrimeGeneratorTest::testPrimeGenerationPerformance":0.424,"PrimeGeneratorTest::testLargePrimeGeneration":1.592,"PrimeGeneratorTest::testPrimeProperties":0.388,"PrimalityComparisonTest::testSmallNumberComparison":0.004,"PrimalityComparisonTest::testMediumNumberComparison":1.813,"PrimalityComparisonTest::testLargeNumberProbabilisticOnly":1.038,"PrimalityComparisonTest::testAccuracyComparison":0.008}}
{"version":2,"defects":{"PrimeNumberTest::testIsPrime":8,"PrimeNumberTest::testModPow":8,"PrimeNumberTest::testLargePrimeNumbers":8,"PrimeNumberTest::testEdgeCases":8,"IntegerTest::testIntegerValidations":7,"IntegerTest::testDivisionByBiggerDivisorException":7,"PrimeGeneratorTest::testGeneratePrime":7,"PrimeGeneratorTest::testPrimeGenerationPerformance":8,"PrimeGeneratorTest::testLargePrimeGeneration":8,"PrimalityComparisonTest::testSmallNumberComparison":7},"times":{"IntegerTest::testIntegerValidations":0.002,"IntegerTest::testInvalidNumberException":0,"IntegerTest::testCreateDefault":0,"IntegerTest::testCreateByInt":0,"IntegerTest::testCreateByString":0,"IntegerTest::testPrint":0,"IntegerTest::testAdd":0.12,"IntegerTest::testLargeAddition":0,"IntegerTest::testSubtract":0.086,"IntegerTest::testLargeSubtraction":0,"IntegerTest::testNegativeSubtraction":0,"IntegerTest::testSubtractWithNegativeResults":0.174,"IntegerTest::testLargeNegativeSubtraction":0,"IntegerTest::testMultiplyByInt":0,"IntegerTest::testMultiplyByIntException":0,"IntegerTest::testMultiply":0.388,"IntegerTest::testGreaterThan":0.046,"IntegerTest::testGreaterOrEqualTo":0,"IntegerTest::testStringLength":13.764,"IntegerTest::testMaximumMultiplier":0.026,"IntegerTest::testMaxMultiplierException":0,"IntegerTest::testNumberLength":0,"IntegerTest::testDivision":0.002,"IntegerTest::testDivisionByZeroException":0,"IntegerTest::testDivisionByBiggerDivisorException":0,"IntegerTest::testSeveralDivisions":0.062,"IntegerTest::testModule":0,"IntegerTest::testCreatingLargeNumber":0,"PrimeNumberTest::testIsPrime":0.013,"PrimeNumberTest::testIsProbablePrime":0,"PrimeNumberTest::testModPow":0,"PrimeNumberTest::testGcd":0,"PrimeNumberTest::testLcm":0,"PrimeNumberTest::testLargePrimeNumbers":0.163,"PrimeNumberTest::testEdgeCases":0,"PrimeGeneratorTest::testGenerateRandomOdd":0,"PrimeGeneratorTest::testGeneratePrime":0.409,"PrimeGeneratorTest::testGeneratePrimeSmallBits":0.012,"PrimeGeneratorTest::testGenerateTwinPrimes":0.329,"PrimeGeneratorTest::testGenerateNextPrime":0.008,"PrimeGeneratorTest::testGeneratePrimesInRange":0.029,"PrimeGeneratorTest::testGenerateRandomPrimeInRange":0.008,"PrimeGeneratorTest::testGenerateSophieGermainPrime":0.505,"PrimeGeneratorTest::testInvalidBitLength":0,"PrimeGeneratorTest::testInvalidBitLengthRandomOdd":0,"PrimeGeneratorTest::testPrimeGenerationPerformance":0.373,"PrimeGeneratorTest::testLargePrimeGeneration":1.24,"PrimeGeneratorTest::testPrimeProperties":0.402,"PrimalityComparisonTest::testSmallNumberComparison":0.003,"PrimalityComparisonTest::testMediumNumberComparison":1.705,"PrimalityComparisonTest::testLargeNumberProbabilisticOnly":1.021,"PrimalityComparisonTest::testAccuracyComparison":0.008}}
21 changes: 16 additions & 5 deletions tests/PrimalityComparisonTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,20 @@ public function testSmallNumberComparison()
$this->assertTrue($probResult);
$this->assertTrue($bruteResult);

// For small numbers, both should be fast (under 100ms in CI environment)
$this->assertTrue($probTime < 100, "Probabilistic test took too long: {$probTime}ms");
$this->assertTrue($bruteTime < 100, "Brute force test took too long: {$bruteTime}ms");
// For small numbers, both should be fast (under 500ms in very slow CI environments)
$this->assertTrue($probTime < 500, "Probabilistic test took too long: {$probTime}ms");
$this->assertTrue($bruteTime < 500, "Brute force test took too long: {$bruteTime}ms");

// Both methods should give correct results
$this->assertTrue($probResult === $bruteResult, "Results should match");

// Log performance for debugging
echo "Performance: Probabilistic={$probTime}ms, Brute Force={$bruteTime}ms\n";

// Additional debugging for CI environments
if ($probTime > 100 || $bruteTime > 100) {
echo "WARNING: Tests are running slowly - this may be a CI environment with Xdebug enabled\n";
}
}

public function testMediumNumberComparison()
Expand Down Expand Up @@ -67,11 +75,14 @@ public function testMediumNumberComparison()
$this->assertTrue($bruteResult);

// For medium numbers, probabilistic should be significantly faster
// Allow for some variance in CI environments
$this->assertTrue($probTime < $bruteTime * 0.8, "Probabilistic should be faster for medium numbers");
// Allow for more variance in CI environments with Xdebug
$this->assertTrue($probTime < $bruteTime * 0.9, "Probabilistic should be faster for medium numbers");

// Both methods should give correct results
$this->assertTrue($probResult === $bruteResult, "Results should match");

// Log performance for debugging
echo "Performance: Probabilistic={$probTime}ms, Brute Force={$bruteTime}ms\n";
}

public function testLargeNumberProbabilisticOnly()
Expand Down