Handle disconnect when channel is not initialized #23
+46
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![orca-security-us[bot]](https://avatars.githubusercontent.com/in/276250?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
| Passed |
OSS Licenses | 0 0 0 0 |
View in Orca |
| Passed |
SAST | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
yordis
force-pushed
the
yordis/fixes-22
branch
from
9b472c2 to
edba61d
Compare
Contributor
Author
|
@guisehn would this work to close the issue? Any idea on how to properly test this 😭 |
yordis
force-pushed
the
yordis/fixes-22
branch
from
8902d04 to
e89eb5d
Compare
yordis
commented
Jan 3, 2026
Comment on lines
+257
to
+266
| if state.channel do | ||
| state.on_disconnect.() | ||
| state.channel.adapter.disconnect(state.channel) | ||
|
|
||
| :telemetry.execute( | ||
| [:conn_grpc, :channel, :disconnected], | ||
| %{duration: now - state.connection_start}, | ||
| telemetry_metadata(state) | ||
| ) | ||
| end |
Contributor
Author
There was a problem hiding this comment.
I am not sure if I am correct here to check for nil and trigger the telemetry when it actually happens.
While also, if that is the case that I need to check nil should I still call state.on_disconnect.() regardless of nil channel or not?
Contributor
There was a problem hiding this comment.
I think it's fine not to do anything when channel is nil.
yordis
force-pushed
the
yordis/fixes-22
branch
from
e89eb5d to
da37032
Compare
fixes TheRealReal#22 Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
yordis
force-pushed
the
yordis/fixes-22
branch
from
da37032 to
e118e4b
Compare
guisehn
approved these changes
Jan 5, 2026
Contributor
guisehn
left a comment
guisehn
left a comment
There was a problem hiding this comment.
Thanks for the contribution! 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yordis Prieto yordis.prieto@gmail.com