feat: add linkedin account to profiles#181
Merged
joelamouche merged 2 commits intomainfrom Mar 2, 2026
Merged
Conversation
tusharshah21
requested review from
Teddy1792,
joelamouche and
oscarwroche
as code owners
joelamouche
requested changes
Mar 2, 2026
Contributor
joelamouche
left a comment
joelamouche
left a comment
There was a problem hiding this comment.
Overall looks great. Just two tests are missing
| let err = update_profile(repo.clone(), profile2.address.to_string(), req).await; | ||
| assert!(err.is_err()); | ||
| assert!(err.unwrap_err().contains("LinkedIn account already taken")); | ||
| } |
Contributor
There was a problem hiding this comment.
Two missing tests:
- successfully create profile with linkedin account at creation (you can reuse existing create test)
- successfully update linkedin account on a profile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds
linkedin_accountsupport to profile storage and existing profile APIs, including case-insensitive global uniqueness and validation behavior defined in BE #163.Changes
linkedin_accountto theprofilestable with a unique index onLOWER(linkedin_account)to enforce global case-insensitive uniqueness.PUT /profiles/:address) to accept optionallinkedin_account.linkedin_accountin existing profile response DTOs (GETprofile endpoints and profile-related responses).