Open
Conversation
* Fix sign text corrupts. Do not pass `org.bukkit.block.Sign` around since there is no guaranty that it is valid after `org.bukkit.block.Sign#update()`. * Fix thread-safety issue with `onPlayerChat`. * Fix gun fires when repairing barrier via sign. * Fix player was able to change text on sign. * Fix zombie spawnpoint selection logic. * Add barrier break and repair progress display. * Use barrier block count - 1 as max break/fix level. * Replace RNG with the more modern one. * And many other low-level fixes, refactors and improvements. Resolve TheTurkeyDev#97.
Contributor
|
Seems like a very good PR, know I did go through some things and it looks good. What do you think about this PR @TheTurkeyDev ? |
TheTurkeyDev
added a commit
that referenced
this pull request
Jan 3, 2025
Make all of the logging and prefixes consistant and uniform Added some changes from PR #155
Contributor
|
No further progress @TheTurkeyDev |
Owner
|
I've cherry picked and implemented a lot of these changes myself, but not all. May just close this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
org.bukkit.block.Signaround since there is no guaranty that it is valid afterorg.bukkit.block.Sign#update().onPlayerChat.Resolve #97.