Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation / Background
The current subscriber implementation directly constructs a net/http.Server, which tightly couples the subscriber to a single HTTP server implementation.
While this works well today, it makes it harder to extend the subscriber to support alternative server setups and customise server behaviour without modifying core subscriber logic.
Details
This PR introduces a small abstraction to decouple server creation while keeping backward compatibility.
Alternative approaches considered (if applicable)
Exposing http.Server directly in config. Avoided because
Checklist
make up.make test_shortfor a quick check.make test.