Update Makefile (for building on Linux and OS X)#14
Update Makefile (for building on Linux and OS X)#14NOTtheMessiah wants to merge 2 commits intoTidal-Stream:masterfrom
Conversation
KSPAPIExtension's functionality has been integrated into the mod (via KSPUtils.cs, UnityUtils.cs, EngineWrapper.cs, and MathUtils.cs) yet the Makefile hasn't been updated to reflect this in 3 years.
"Consider adding a reference to assembly `UnityEngine.UI, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null'"
| $e | ||
|
|
||
| RESGEN2 := resgen2 | ||
| GMCS := gmcs |
There was a problem hiding this comment.
Why are you changing gmcs to mcs?
There was a problem hiding this comment.
I'm using Mono, which has unified the various c# compilers into mcs. I don't know if this is the case on other systems or not.
https://www.mono-project.com/docs/about-mono/languages/csharp/
There was a problem hiding this comment.
So Mono 2.11 unified them. If this is the case, replace the GMCS variable with MCS as well. GMCS := gmcs makes sense but GMCS := mcs does not.
There was a problem hiding this comment.
In addition, it would be good to add -langversion:ISO-2 -sdk:2 after ${GMCS} to make sure we target the same version as gmcs.
There was a problem hiding this comment.
Nice thought, but it won't compile because there's lambda expressions and other language features used not in the C# 2.0 specification.
KSPAPIExtension's functionality has been integrated into the mod (via KSPUtils.cs, UnityUtils.cs, EngineWrapper.cs, and MathUtils.cs) yet the Makefile hasn't been updated to reflect this in 3 years.