feat: Schematron validation using Saxon Home Edition (Java) by qdequippe · Pull Request #11 · Tiime-PDP/cdar

qdequippe · 2026-02-19T17:17:40Z

No description provided.

Copilot

Pull request overview

This PR introduces Schematron business-rule validation for CDAR XML documents by running a precompiled Schematron XSLT with Saxon (Java) and parsing the resulting SVRL output into structured validation errors.

Changes:

Add a Saxon (JAR) backed SchematronValidatorInterface implementation that executes java -jar and extracts svrl:failed-assert entries.
Add PHPUnit coverage and test fixtures for successful and failing Schematron validation.
Add operational support for CI/Docker (Saxon download + SAXON_JAR env) and add symfony/process as a dependency.

Reviewed changes

Copilot reviewed 11 out of 13 changed files in this pull request and generated 12 comments.

Show a summary per file

File	Description
`xslt/20260216_BR-FR-CDV-Schematron-CDAR_V1.3.0.xsl`	Adds the compiled Schematron XSLT ruleset that Saxon will execute to produce SVRL.
`src/Schematron/SchematronValidatorInterface.php`	Defines the contract for Schematron validators.
`src/Schematron/SaxonJarSchematronValidator.php`	Implements Schematron validation via Saxon JAR and SVRL parsing.
`src/Schematron/ValidationError.php`	Introduces a value object for individual SVRL failed-assert details.
`src/Schematron/ValidationFailedException.php`	Adds a typed exception carrying collected validation errors.
`tests/Schematron/SaxonJarSchematronValidatorTest.php`	Adds unit tests for success and failure validation flows.
`tests/data/UC1_F202500003_01-CDV-200_Deposee.xml`	Updates a validation fixture to satisfy new/stricter rules.
`docs/SaxonJarSchematronValidator.md`	Documents requirements and usage for the new validator.
`composer.json`	Adds `symfony/process` to support running Saxon as a subprocess.
`Dockerfile`	Adds a container setup including Java + Saxon HE and `SAXON_JAR` env.
`.github/workflows/tests.yml`	Downloads/caches Saxon in CI and exports `SAXON_JAR` for tests.

src/Schematron/SaxonJarSchematronValidator.php

docs/SaxonJarSchematronValidator.md

tests/data/20260216_BR-FR-CDV-Schematron-CDAR_V1.3.0.xsl

src/Schematron/SaxonJarSchematronValidator.php

tests/Schematron/SaxonJarSchematronValidatorTest.php

tests/data/20260216_BR-FR-CDV-Schematron-CDAR_V1.3.0.xsl

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 11 out of 13 changed files in this pull request and generated 9 comments.

src/Schematron/ValidationError.php

src/Schematron/ValidationFailedException.php

Dockerfile

Copilot · 2026-02-19T17:33:35Z

src/Schematron/ValidationError.php

+final readonly class ValidationError
+{
+    private string $test;
+
+    private string $id;
+
+    private string $flag;
+
+    private string $location;
+
+    private ?string $text;
+
+    public function __construct(
+        string $test,
+        string $id,
+        string $flag,
+        string $location,
+        ?string $text,
+    ) {
+        $this->test = $test;
+        $this->id = $id;
+        $this->flag = $flag;
+        $this->location = $location;
+        $this->text = $text;
+    }


The ValidationError class lacks PHPDoc comments for its properties and methods, which is inconsistent with the SchemaValidationError class in the same codebase that includes detailed PHPDoc for all properties. For consistency and better IDE support, add PHPDoc comments describing what each property represents (test, id, flag, location, text).

Copilot · 2026-02-19T17:33:35Z

src/Schematron/SaxonJarSchematronValidator.php

+
+        if (false === extension_loaded('dom') || false === extension_loaded('libxml')) {
+            throw new \LogicException('DOM and Libxml extensions are required to validate business rules.');
+        }


The validator does not check if the Saxon JAR file exists and is readable before attempting to execute it. If the file doesn't exist or isn't accessible, the error will only surface when the Process runs, leading to a less clear error message. Consider adding a validation check in the constructor to verify the Saxon JAR file exists and is readable, throwing a clear \LogicException if not.

Suggested change

}

}

if (false === is_file($this->saxonJar) || false === is_readable($this->saxonJar)) {

throw new \LogicException(sprintf('Saxon JAR file "%s" does not exist or is not readable.', $this->saxonJar));

}

Copilot · 2026-02-19T17:33:36Z

src/Schematron/SaxonJarSchematronValidator.php

+    public function validate(string $xmlFilepath, string $xsltFilepath): void
+    {
+        $process = new Process([
+            'java',
+            '-jar',
+            $this->saxonJar,
+            '-s:'.$xmlFilepath,
+            '-xsl:'.$xsltFilepath,
+        ]);


The validate method does not check if the input XML file and XSLT file exist and are readable before passing them to the Saxon process. If either file doesn't exist, Saxon will fail with potentially unclear error messages. Consider adding file existence checks at the beginning of the validate method and throwing a clear exception (e.g., \InvalidArgumentException) if files are missing or not readable.

Copilot · 2026-02-19T17:33:36Z

tests/data/20260216_BR-FR-CDV-Schematron-CDAR_V1.3.0.xsl

+        [BR-FR-CDV-CL-09/MDT-113_501] : Le code motif de statut (MDT-113) : "<xsl:text/>
+                  <xsl:value-of select="."/>
+                  <xsl:text/>", n'est pas dans la liste des codes autorisés pour le statut IRRECEVABLE (501) :
+        "IRR_VIDE_F", "IRR_TYPE_F", "IRR_SYNTAX", "IRR_TAILLE_PJ", "IRR_NOM_PJ", "IRR_VID_PJ", "IRR_EXT_DOC, "IRR_TAILLE_F", "IRR_ANTIVIRUS". Veuillez corriger cette valeur si nécessaire.


The XSLT file contains a typo at line 1673. There is a missing closing quote after "IRR_EXT_DOC". The string reads "IRR_EXT_DOC, "IRR_TAILLE_F"" but should be "IRR_EXT_DOC", "IRR_TAILLE_F"" (note the missing quote after IRR_EXT_DOC and the comma should be inside the quotes).

Suggested change

"IRR_VIDE_F", "IRR_TYPE_F", "IRR_SYNTAX", "IRR_TAILLE_PJ", "IRR_NOM_PJ", "IRR_VID_PJ", "IRR_EXT_DOC, "IRR_TAILLE_F", "IRR_ANTIVIRUS". Veuillez corriger cette valeur si nécessaire.

"IRR_VIDE_F", "IRR_TYPE_F", "IRR_SYNTAX", "IRR_TAILLE_PJ", "IRR_NOM_PJ", "IRR_VID_PJ", "IRR_EXT_DOC", "IRR_TAILLE_F", "IRR_ANTIVIRUS". Veuillez corriger cette valeur si nécessaire.

Copilot · 2026-02-19T17:33:36Z

tests/data/20260216_BR-FR-CDV-Schematron-CDAR_V1.3.0.xsl

+   <!--PATTERN BR-FR-CDV-15BR-FR-CDV-14 — Vérification des caractéristiques en cas de statut "Encaissé"-->
+   <svrl:text xmlns:svrl="http://purl.oclc.org/dsdl/svrl">BR-FR-CDV-14 — Vérification des caractéristiques en cas de statut "Encaissé"</svrl:text>


The XSLT pattern name at line 1084 says "BR-FR-CDV-14" but the pattern ID is "BR-FR-CDV-15". This is inconsistent - the pattern name should match the pattern ID for clarity and maintainability. Based on the context (this is the 15th BR-FR-CDV pattern), it should be "BR-FR-CDV-15" in the name as well.

Suggested change



<svrl:text xmlns:svrl="http://purl.oclc.org/dsdl/svrl">BR-FR-CDV-14 — Vérification des caractéristiques en cas de statut "Encaissé"</svrl:text>



<svrl:text xmlns:svrl="http://purl.oclc.org/dsdl/svrl">BR-FR-CDV-15 — Vérification des caractéristiques en cas de statut "Encaissé"</svrl:text>

src/Schematron/SaxonJarSchematronValidator.php

qdequippe requested a review from Copilot February 19, 2026 17:17

qdequippe self-assigned this Feb 19, 2026

Copilot started reviewing on behalf of qdequippe February 19, 2026 17:18 View session

qdequippe added 2 commits February 19, 2026 18:22

feat: Schematron validation using Saxon Java

89e5f9e

fix code style, phpstan and tests

3d47295

qdequippe force-pushed the saxon-java branch from 5d2e29d to 3d47295 Compare February 19, 2026 17:22

qdequippe requested a review from samueld-pdp February 19, 2026 17:22

Copilot AI reviewed Feb 19, 2026

View reviewed changes

qdequippe and others added 3 commits February 19, 2026 18:26

Apply suggestions from code review

d8eb453

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

apply reviews

ca43b48

Update docs/SaxonJarSchematronValidator.md

a8455de

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

qdequippe requested a review from Copilot February 19, 2026 17:28

Copilot started reviewing on behalf of qdequippe February 19, 2026 17:29 View session

Copilot AI reviewed Feb 19, 2026

View reviewed changes

update gitattributes

b92ac35

qdequippe changed the title ~~feat: Schematron validation using Saxon Java~~ feat: Schematron validation using Saxon Home Edition (Java) Feb 19, 2026

-        }
+        }
+        if (false === is_file($this->saxonJar) || false === is_readable($this->saxonJar)) {
+            throw new \LogicException(sprintf('Saxon JAR file "%s" does not exist or is not readable.', $this->saxonJar));
+        }

	"IRR_VIDE_F", "IRR_TYPE_F", "IRR_SYNTAX", "IRR_TAILLE_PJ", "IRR_NOM_PJ", "IRR_VID_PJ", "IRR_EXT_DOC, "IRR_TAILLE_F", "IRR_ANTIVIRUS". Veuillez corriger cette valeur si nécessaire.
	"IRR_VIDE_F", "IRR_TYPE_F", "IRR_SYNTAX", "IRR_TAILLE_PJ", "IRR_NOM_PJ", "IRR_VID_PJ", "IRR_EXT_DOC", "IRR_TAILLE_F", "IRR_ANTIVIRUS". Veuillez corriger cette valeur si nécessaire.

		<!--PATTERN BR-FR-CDV-15BR-FR-CDV-14 — Vérification des caractéristiques en cas de statut "Encaissé"-->
		<svrl:text xmlns:svrl="http://purl.oclc.org/dsdl/svrl">BR-FR-CDV-14 — Vérification des caractéristiques en cas de statut "Encaissé"</svrl:text>

Comments

Conversation

qdequippe commented Feb 19, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant