Conversation
tdbbyd
force-pushed
the
st4tdb/update_endpoints
branch
from
82031b8 to
ce75b6f
Compare
tdbbyd
force-pushed
the
st4tdb/update_endpoints
branch
from
ce75b6f to
a8f1f04
Compare
ryan-williams
left a comment
ryan-williams
left a comment
There was a problem hiding this comment.
Couple questions… I'm also unclear which of these diffs are due to:
- Changed openapi-generator version
- Bumped core version (2.2.19 to 2.17.51)
- Other changes introduced manually
I'm new to this repo, so any context you can provide for understanding the "big picture" would be appreciated, ty!
.openapi-generator/FILES
Outdated
| src/test/java/io/tiledb/cloud/rest_api/model/UDFTypeTest.java | ||
| src/test/java/io/tiledb/cloud/rest_api/model/UserTest.java | ||
| src/test/java/io/tiledb/cloud/rest_api/model/WriterTest.java | ||
| src/main/java/org/openapitools/client/ApiCallback.java |
There was a problem hiding this comment.
Are these "renames" intentional?
.openapi-generator/VERSION
Outdated
| @@ -1 +1 @@ | |||
| 7.7.0 | |||
| 6.0.1 No newline at end of file | |||
There was a problem hiding this comment.
Would be good to use the same version, to rule out spurious diffs introduced by a changed version.
Looks like 7.12.0 is latest, atm, but I'd suggest changing the version as a separate PR
There was a problem hiding this comment.
Good catch. I think it is better if we use the latest version in a separate PR
There was a problem hiding this comment.
What about just using the same version that was previously used? (7.7.0)
Just trying to rule out introducing spurious changes from going backwards on the version here.
|
Many changes are just dates or doc changes. Everything is auto generated. We have decided that when this gets merged to main it will act as the dev branch for the new server. We will then need to add tests etc. It is in a very preliminary form now, and will be mainly used for the udfs |
|
The stable and current version has been branched here. https://github.com/TileDB-Inc/TileDB-Cloud-Java/tree/release-0.5.0 |
ryan-williams
left a comment
ryan-williams
left a comment
There was a problem hiding this comment.
Sorry if I've missed it: are the command(s) you used for this documented somewhere?
I skimmed the changes and they seem reasonable, but I'm missing some context about how the changes were generated.
.openapi-generator/VERSION
Outdated
| @@ -1 +1 @@ | |||
| 7.7.0 | |||
| 6.0.1 No newline at end of file | |||
There was a problem hiding this comment.
What about just using the same version that was previously used? (7.7.0)
Just trying to rule out introducing spurious changes from going backwards on the version here.
ryan-williams
force-pushed
the
st4tdb/update_endpoints
branch
from
8f9dcf8 to
45e0da0
Compare
Update local copy of spec from [`TileDB-Server//openapi/v1to3/src/openapi-v1.yaml`](https://github.com/TileDB-Inc/TileDB-Server/blob/main/openapi/v1to3/src/openapi-v1.yaml): ```bash gh api \ -H "Accept: application/vnd.github.raw" \ /repos/TileDB-Inc/TileDB-Server/contents/openapi/v1to3/src/openapi-v1.yaml \ > openapi-v1.yaml ```
ryan-williams
force-pushed
the
st4tdb/update_endpoints
branch
from
399aeee to
45e0da0
Compare
3 participants
This PR updates the client to use the carrara endpoints for v1 only at the moment. The build.gradle has been changed to use the SNAPSHOT channel for pre-releases until carrara is out