Conversation
Comment on lines
+717
to
+719
| TILEDB_DATA_PROTOCOL_V2 DataProtocol = C.TILEDB_DATA_PROTOCOL_v2 | ||
| // REST API v3 (TileDB 3.0+) | ||
| TILEDB_DATA_PROTOCOL_V3 DataProtocol = C.TILEDB_DATA_PROTOCOL_v3 |
Member
Author
There was a problem hiding this comment.
🤔 I agree it's the expected format for golang, but the rest of our enumerations use the TILEDB_ format. If we want to switch to this format IMO we should be consistent and update them all. We can open a story to do this in future releases if you'd like, provided there are no objections from others.
We'd need to go through a deprecation cycle to rename the existing enumerations. At the end of that cycle we could start using this format moving forward, so we don't have any mixed conventions for enumerations in the meantime.
Member
There was a problem hiding this comment.
Fair enough, that's something to consider if we ever do a TileDB-Go-v2.
teo-tsirpanis
approved these changes
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates to TileDB 2.30 and wraps the new
tiledb_ctx_get_data_protocolAPI added in TileDB-Inc/TileDB#5697.