Use pointer instead of iterator for thread safe unordered_map usage#5749
Merged
Use pointer instead of iterator for thread safe unordered_map usage#5749
Conversation
Member
teo-tsirpanis
left a comment
There was a problem hiding this comment.
We are under a reader lock; how is this unsafe? Writes aren't suppose to happen during that code path.
Member
Author
There is a |
teo-tsirpanis
approved these changes
Feb 12, 2026
Member
teo-tsirpanis
left a comment
There was a problem hiding this comment.
Approved per offline explanation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reading remote global order writes code, chasing a corruption issue, I spotted that we were accessing an iterator of an
unordered_mapwithout synchronization which is not thread safe (afaik concurrentemplace()calls for other URIs may trigger anunordered_maprehash which invalidates iterators). I replaced the iterator with a pointer to the data instead to fix thisRelates to CLOUD-3368
TYPE: BUG
DESC: Use pointer instead of iterator for thread safe unordered_map usage