Skip to content

feat: Added storage change alerts for critical keys to close #104#303

Merged
Timi16 merged 1 commit intoTimi16:mainfrom
Oluwaseyi89:feature/Add-Storage-Change-Alerts-for-Critical-Keys
Feb 26, 2026
Merged

feat: Added storage change alerts for critical keys to close #104#303
Timi16 merged 1 commit intoTimi16:mainfrom
Oluwaseyi89:feature/Add-Storage-Change-Alerts-for-Critical-Keys

Conversation

@Oluwaseyi89
Copy link
Contributor

Description

This PR introduces storage change alerts that notify users when critical storage keys are modified during execution. Users can now define specific keys or patterns to monitor, with alerts displayed prominently in both terminal output and JSON format.

Key Features

  • Critical Key Definition: Add --alert-on-change flag (repeatable) to specify keys to monitor
  • Wildcard Support: Pattern matching with * (e.g., balance:*, admin:*)
  • Prominent Warnings: Clear visual alerts when monitored keys are modified
  • JSON Output Integration: Alerts included in structured JSON output for programmatic use

Implementation Details

  • Updated src/inspector/storage.rs to detect and flag critical key modifications during diff calculation
  • Added support for both exact key matching and wildcard patterns
  • Implemented warning display with visual prominence in terminal output
  • Integrated alerts into JSON response structure

Testing

Added comprehensive integration tests:

  • tests/integration/storage_alert_tests.rs - Tests covering:
    • Exact key matching
    • Wildcard pattern matching
    • Multiple alert flags
    • JSON output verification
    • No false positives on non-critical keys

Closes #104

@Oluwaseyi89
Copy link
Contributor Author

@Timi16 please, review.

@Timi16
Copy link
Owner

Timi16 commented Feb 26, 2026

@Timi16 please, review.

Reviewing

@Timi16 Timi16 merged commit e736bb6 into Timi16:main Feb 26, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Storage Change Alerts for Critical Keys

2 participants