Fix external repo resolver process cleanup#317
Open
sharmila-oai wants to merge 1 commit intoTinder:masterfrom
Open
Fix external repo resolver process cleanup#317sharmila-oai wants to merge 1 commit intoTinder:masterfrom
sharmila-oai wants to merge 1 commit intoTinder:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
When
ExternalRepoResolverrunsbazel queryto resolve canonical bzlmod external repo paths, it reads only the first line and returns immediately. Without explicitly closing stdin/stderr and terminating the child process, the spawned Bazel query can continue running in the background. This can leak subprocesses and create avoidable resource pressure during fine-grained external repo hashing.What changed
runProcessAndCaptureFirstLineto:terminateProcesshelper that:destroy)destroyForcibly) if neededValidation
bazel test //cli:SourceFileHasherTestbazel test //cli:SourceFileHasherTest //cli:E2ETestfor this exact patch