fix escapeJavaScript for quotes: double escape the double quote#9
Open
jlongman wants to merge 3 commits intoToQoz:masterfrom
Open
fix escapeJavaScript for quotes: double escape the double quote#9jlongman wants to merge 3 commits intoToQoz:masterfrom
jlongman wants to merge 3 commits intoToQoz:masterfrom
Conversation
Author
|
ack realized I forgot the conventional commit style, will try to revise but I'm in the browser atm. |
ref: ToQoz#8 double quote the string used in `util.escapeJsonString`. Note, I notice the existing test - https://github.com/jlongman/api-gateway-mapping-template/blob/master/test/util.js#L5 - this would presumably break this test? I may add the test in the original issue to the PR. Thinking about this, maybe this suggests a difference in runtime environments? Will add notes to the issue.
jlongman
force-pushed
the
8-double-escape-quotes-in-escapeJavaScript
branch
from
c78c85e to
6304feb
Compare
Author
|
branch is updated with an additional test that embeds the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: #8
double quote the string used in
util.escapeJsonString.Note, I notice the existing test - https://github.com/jlongman/api-gateway-mapping-template/blob/master/test/util.js#L5 - this would presumably break this test? I may add the test in the original issue to the PR.
Thinking about this, maybe this suggests a difference in runtime environments? Will add notes to the issue.