Add when_matched support to non-idempotent time-range materialization#11
Open
0xRobin wants to merge 1 commit intoTobikoData:mainfrom
Open
Add when_matched support to non-idempotent time-range materialization#110xRobin wants to merge 1 commit intoTobikoData:mainfrom
0xRobin wants to merge 1 commit intoTobikoData:mainfrom
Conversation
Parse and validate optional materialization_properties.when_matched and pass it through to adapter.merge so update clauses can preserve immutable columns like _inserted_at.
bfb9ef6 to
bd005ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
materialization_properties.when_matchedsupport tonon_idempotent_incremental_by_time_range.when_matchedusing SQLMesh's expression validation and merge-alias replacement semantics, then pass it through toadapter.merge(...).WHEN MATCHEDclauses are respected in generated MERGE SQL.Why
non_idempotent_incremental_by_time_rangecurrently always updates all columns on key match. This makes it impossible to keep immutable ingestion metadata such as_inserted_atunchanged on updates. Supportingwhen_matchedgives model authors explicit control over update behavior while preserving existing defaults when unset.Implementation Notes
This follows SQLMesh's existing
INCREMENTAL_BY_UNIQUE_KEYflow:IncrementalByUniqueKeyKind.when_matchedparsing/validation:when_matchedinto merge in strategy:when_matchedhandling:Validation
uv run pytest tests/materializations/test_non_idempotent_incremental_by_time_range.py -q