Open
Conversation
✅ Deploy Preview for keen-boyd-1443aa ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Author
|
Quick video running on an iphone trim.EC3B5650-F30B-4AF5-8B9E-F738403E4B40.MOV |
scottshambaugh
force-pushed
the
touch_interface
branch
from
cfd98f1 to
54ba440
Compare
Author
|
Also this pushes the lines to over 10000, so this comment should be addressable now #351 (comment) |
scottshambaugh
force-pushed
the
touch_interface
branch
2 times, most recently
from
900bbcf to
8970223
Compare
scottshambaugh
force-pushed
the
touch_interface
branch
from
8970223 to
c270c25
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Lu, I watched your SPATIAL PROGRAMMING WITHOUT ESCAPE video today and was totally captivated!
I saw in the readme that there wasn't touch support. So I figured I'd add it. Everything works as expected as far as I can tell, and you can multitouch with two fingers to pinch-zoom and pan around the grid. Long pressing >500 ms works like right clicking, to either sample a color in the grid, or generate a random one outside of it, or create a new combined atom from the paddle area, or clone new atoms from existing ones. No comments since the rest of the file doesn't have them, but would be happy to document this better if you'd like. This closes #86.
The one behavior that needed to be changed/added was moving the paddles up and down by clicking and dragging them, rather than only with alt-scroll. But that's in too, and it works nicely I think. Scrolling unlocks once you have more than 2 paddles, and is clamped so you can't lose them offscreen. That helps with the scrolling bit of #101, closes #53, and I also ran into #159 which I think should be fixed now by making sure paddles are at the bottom.
I also couldn't immediately think of a way to nicely change the brush size with touch only, so touches are forced to a size 0 brush.
I tested everything on my Windows touchscreen laptop running Firefox and on my iPhone running safari, and things seem to work well both places.
Pleased to have joined the ritual!
ribbit