Adding support for Accelerate launch#4
Open
hmcgovern wants to merge 3 commits intoTomLippincott:masterfrom
Open
Adding support for Accelerate launch#4hmcgovern wants to merge 3 commits intoTomLippincott:masterfrom
hmcgovern wants to merge 3 commits intoTomLippincott:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this pull request, I modify the regex found in
src/steamroller/engines/local_engine.pyandsrc/steamroller/engines/slurm_engine.pyto allow for launching either with Python or with 'accelerate launch' to allow compatibility with the accelerate module for multi-GPU training/inference.N.B.
accelerate configshould still be run prior to launching scripts, as this regex does not parse additional command line arguments given to accelerate, such as--num_processes.