Fix required tag updates for policy tag lists#75
Draft
Tony-MK wants to merge 1 commit intoTags-Violationsfrom
Draft
Fix required tag updates for policy tag lists#75Tony-MK wants to merge 1 commit intoTags-Violationsfrom
Tony-MK wants to merge 1 commit intoTags-Violationsfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
requiresTagflag that occurred due to attempting to spread or merge undefined tag list entries when building updated policy tag data.Description
getUpdatedTagsDatainsrc/libs/actions/Policy/Tag.tsto iterate overpolicyData.tags ?? {}and guard against missing tag lists by skipping undefined entries and merging from the actualtagListinstead of spreading possibly-undefined accumulator entries.Testing
npm test -- --runTestsByPath tests/actions/PolicyTagTest.ts, butjestwas not available in the environment so automated tests could not be executed.Codex Task