fix when required multiple times #101
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qqshfox
force-pushed
the
required_multiple_times
branch
3 times, most recently
from
c4fd98f to
3288be7
Compare
qqshfox
force-pushed
the
required_multiple_times
branch
from
3288be7 to
e8de3d7
Compare
qqshfox
force-pushed
the
required_multiple_times
branch
from
e8de3d7 to
1bc2538
Compare
|
any reason this wasn't merged yet? I just ran into this exact issue with the latest versions of ref and jest so a fix would be much appreciated |
|
stumbled into this issue too, lots of time wasted |
javihernandez
added a commit
to javihernandez/ref
that referenced
this pull request
May 9, 2020
* bruceauyeung/node-12: fix when required multiple times:revert mistakenly modified codes in previous commit fix when required multiple times:TooTallNate#101 support node 12: modified as suggested from TooTallNate#114 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same problem as #76 but fixed in the right way, IMAO.
mocha 4+ drops supports for old node versions. https://github.com/mochajs/mocha/releases/tag/v4.0.0
nan 2.8.0 don't work with io.js 3.2. nodejs/nan#725