Support Node v12.0.0 #114
Open
Support Node v12.0.0 #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 31, 2019
|
Any update on Node.js 12 Support? |
|
Nan::To<bool>(info[3]).FromJust();instead of info[3]->BooleanValue(v8::Isolate::GetCurrent()->GetCurrentContext()).ToChecked();the latter is very ugly |
javihernandez
added a commit
to javihernandez/ref
that referenced
this pull request
Oct 10, 2019
javihernandez
added a commit
to javihernandez/ref
that referenced
this pull request
May 9, 2020
* bruceauyeung/node-12: fix when required multiple times:revert mistakenly modified codes in previous commit fix when required multiple times:TooTallNate#101 support node 12: modified as suggested from TooTallNate#114 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.