Consolidate ssh key management into single file #971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmoggr
force-pushed
the
consolidate-ssh-keys
branch
from
23c8252 to
558471d
Compare
jmoggr
force-pushed
the
consolidate-ssh-keys
branch
from
558471d to
9125a0c
Compare
jmoggr
force-pushed
the
consolidate-ssh-keys
branch
from
9125a0c to
aaa5bd8
Compare
Member
|
Thanks! I'll let Kaspar review but I have indeed previously been tripped up by this. |
kasbah
approved these changes
Jan 29, 2026
Member
|
Oops maybe shouldn't have merged due to base not being main but we can still merge #970 all together. Just makes it more annoying to review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we frequently misunderstood and made mistakes about which public keys needed to be defined in which places. This new declarative structure for the public keys should make it much easier to understand what keys are needed where and make adding/editing keys/hosts less error prone.
Stacked on top of #970 due to skill issues with git.