Vectorize atom index computation in L-BFGS optimizer#444
Merged
abhijeetgangan merged 3 commits intoTorchSim:mainfrom Feb 6, 2026
Merged
Vectorize atom index computation in L-BFGS optimizer#444abhijeetgangan merged 3 commits intoTorchSim:mainfrom
abhijeetgangan merged 3 commits intoTorchSim:mainfrom
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
|
Could you run #365 (comment) and see the performance did not regress? |
Contributor
Author
|
Sure, I’ve done two consecutive runs of the script in #365 with and without these changes, and obtained: A second pair of consecutive runs gives: So it looks like, besides timing fluctuations, there might also be some minor optimization. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace Python for-loops over systems with vectorized tensor operations in the L-BFGS optimizer's padding/unpadding helpers and mask construction.