Point14 & RGB14 #1
Conversation
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
There was a problem hiding this comment.
Pull Request Overview
This PR implements Point14 and RGB14 encoding/decoding support for LAZ compression, completing the LAZ 1.4 format implementation. The changes enable encoding and decoding of LASPointFormat6 and LASPointFormat7 (Point14 with RGB) data.
Key changes:
- Implemented complete Point14 encoder with support for all LAS 1.4 point attributes (intensity, classification, flags, user_data, scan_angle, point_source_id, GPS time, and Z coordinate)
- Added RGB14 encoder for color data compression with scanner channel context support
- Extracted arithmetic utility functions to a shared header file
- Updated tests to properly validate encoding/decoding round-trips
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/utilities/arithmetic.hpp | New utility header containing wrapping arithmetic functions extracted from encoders |
| src/laz/point14_encoder.hpp | Complete implementation of Point14 encoder with all field support and context management |
| src/laz/rgb14_encoder.hpp | New RGB14 encoder for color data compression with scanner channel contexts |
| src/laz/point10_encoder.hpp | Refactored to use shared arithmetic utilities |
| src/laz/laz_writer.hpp | Added Point14 and RGB14 encoder initialization |
| src/laz/laz_reader.hpp | Added Point14 and RGB14 decoder support |
| src/laz/encoders.hpp | Updated encoder variant to include Point14 and RGB14 |
| src/laz/tests/test_point14_encoder.cpp | Enhanced test with comprehensive random data and round-trip validation |
| src/laz/tests/test_laz_io.cpp | Added integration test for LASPointFormat7 with Point14 and RGB14 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 21 out of 21 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 23 out of 23 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 30 out of 30 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.