Add TODOs for expanded logging in some logger-kafka-consumer classes#53
Closed
dmccoystephenson wants to merge 1 commit intomainfrom
Closed
Add TODOs for expanded logging in some logger-kafka-consumer classes#53dmccoystephenson wants to merge 1 commit intomainfrom
dmccoystephenson wants to merge 1 commit intomainfrom
Conversation
…imService, and LoggerKafkaConsumer
Base automatically changed from
pr/addressing-comments-for-release-2.0
to
release/v2.0
April 18, 2025 15:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The current implementation of the logger-kafka-consumer lacks sufficient traceability. When data processing fails, the failure may go unnoticed or be difficult for an operator to diagnose.
Solution
TODO comments have been added to key classes within the Logger Kafka Consumer to indicate areas where logging should be improved.
Testing
All unit tests have been run and confirmed to pass.