Speed up rendering#165
Open
andreareina wants to merge 8 commits intoTrimps:masterfrom
andreareina:moar-faster
Open
Speed up rendering#165andreareina wants to merge 8 commits intoTrimps:masterfrom andreareina:moar-faster
andreareina wants to merge 8 commits intoTrimps:masterfrom
andreareina:moar-faster
Conversation
Appending to .innerHTML in a loop causes a parse every loop iteration, which is slow. Instead we accumulate the HTML strings and assign it to .innerHTML in one go so that parsing just happens once. This replaces the need for drawUpgrade(), so I've removed it as well.
Aggregating the style change is a minor speedup, most of the time is spent assigning the cell's `.innerHTML`.
Contributor
Author
|
I think that's about as much as can be done with |
Contributor
Author
|
Benchmarks! trimps.github.io is the regular codebase of course, localhost is mine. # 1 is the liquid zones 1-21, # 2 is the overkilling over one full zone in the 2xx range.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes pretty much either remove modifications to
.innerHTMLwhere HTML isn't needed (e.g. numbers that don't go to infinity) or batch said modifications so that HTML parsing happens only once.One big source of jank I wasn't able to fix is in
drawGrid(), wherecell.innerHTMLis assigned to.