Conversation
|
(review on this is not at all urgent) |
| "plugin:joyent/lint" | ||
| ], | ||
| "parserOptions": { | ||
| "ecmaVersion": 5, |
There was a problem hiding this comment.
eslintrc has ecmaVersion == 6, why the difference? In fact, why the duplication?
There was a problem hiding this comment.
Yeah, I think with .eslintrc, that's all we need. I wonder if eslint.node.conf predated RFD 100's advice for .eslintrc, either way, removing it now.
| "plugin:joyent/lint" | ||
| ], | ||
| "parserOptions": { | ||
| "ecmaVersion": 5, |
| */ | ||
| function linkify(link, text) { | ||
| return ('\x1B]8;;' + link + '\x1B\\' + text + '\x1B]8;;\x1B\\'); | ||
| return '\x1B]8;;' + link + '\x1B\\' + text + '\x1B]8;;\x1B\\'; |
There was a problem hiding this comment.
My JS-ignorance is showing, why lose the parens?
| cb(new VError('failed to get URL of remote "origin": ' | ||
| + err.message)); | ||
| var cfgPath = expandTilde(repoPath + '/.git/config'); | ||
| fs.exists(cfgPath, function(exists) { |
There was a problem hiding this comment.
Just a suggestion. You may want to use fs.access since fs.exists has been deprecated and at some point might start emitting a deprecation warning when invoked. Though it's been deprecated since Node v1.0.0 and still is a documentation-only deprecation so it's not going to cause any issue.
5 participants
No description provided.