Conversation
wordhou
left a comment
wordhou
left a comment
There was a problem hiding this comment.
This is a good start. Two things that come to me right away:
We should try and separate the logic for actually producing the CSV with the logic for handling the files and attaching them to an email, since they are on different levels. (the first is business logic and the second is implementation logic). This may be kind of difficult with the csv library that you've chosen. We may want to store our CSV data in an intermediate format, like a List<List>.
Also we discussed this over discord but we should be able to replace the external file system access with internal file system access.
| public void convertToCsv (Batch batch) throws IOException { | ||
| String path = baseDir + File.separator + "BatchData.csv"; | ||
| File f = new File(path); | ||
| if (f.exists()&& f.isDirectory()){ | ||
| csvWriter= new CSVWriter(new FileWriter(path, true)); | ||
| } else{ | ||
| csvWriter= new CSVWriter(new FileWriter(path)); | ||
| } | ||
|
|
||
| // still need to use intent to save file or email | ||
| List<Measurement> batchMeasurements = batch.getMeasurements(); | ||
| csvWriter.writeNext(new String[] {"Type", "Number", "Identifier", "Created At", "Updated At"}); | ||
| csvWriter.writeNext(new String [] {batch.getType(), String.valueOf(batch.getBatchNumber()), batch.getBatchIdentifier(), batch.getCreatedAt().toString(), batch.getUpdatedAt().toString()}); | ||
| csvWriter.writeNext(new String [] {""}); | ||
| csvWriter.writeNext(new String [] {"True Proof", "Temperature", "Temp. Correction", "Hydrometer", "Hydro Correction", "Created At"}); | ||
| for (Measurement m : batchMeasurements | ||
| ) { | ||
| csvWriter.writeNext(new String [] {String.valueOf(m.getTrueProof()), String.valueOf(m.getTemperature()), | ||
| String.valueOf(m.getTemperatureCorrection()), String.valueOf(m.getHydrometer()), String.valueOf(m.getHydrometerCorrection()) | ||
| , m.getCreatedAt().toString()}); | ||
| } | ||
| csvWriter.close(); | ||
| } |
There was a problem hiding this comment.
Ideally we want this method to be side-effect free and return something, rather than returning void and doing side effects.
My thoughts are to either make this return a String with the contents of the CSV file. Or, if we want to return a file, create the file without Android's API and return a URI.
| <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" /> | ||
| <!-- requests write to storage permission for csv export--> |
There was a problem hiding this comment.
I don't believe we actually need this permission to create a file and attach it to an email. I believe we can accomplish our task without this.
| // +"\",\"" + batch.getCreatedAt().toString()+"\",\"" + batch.getUpdatedAt().toString() | ||
| String combinedString = batchHeader + "\n" + batchInfo; | ||
| File file = null; | ||
| File root = Environment.getExternalStorageDirectory(); |
There was a problem hiding this comment.
Let's see if we can use internal storage rather than external storage so we don't need to request permissions.
2 participants
No description provided.