Skip to content

bugfix: upgrade to version 1.0.1 of redactor#57

Open
thinkrapido wants to merge 1 commit intoTylerGarlick:masterfrom
thinkrapido:devel
Open

bugfix: upgrade to version 1.0.1 of redactor#57
thinkrapido wants to merge 1 commit intoTylerGarlick:masterfrom
thinkrapido:devel

Conversation

@thinkrapido
Copy link

  • pull request takes into account redactor change of callback handling
  • semicolon added due to jshint warning

@GAnatoliy
Copy link

Hi, looks that part that prevent collisions with change callback also should be updated.
Code example:

  angular.merge(options, redactorOptions, additionalOptions);

  // prevent collision with the constant values on ChangeCallback
  var changeCallback = (additionalOptions.callbacks && additionalOptions.callbacks.change) ||
    (redactorOptions.callbacks && redactorOptions.callbacks.change);
  if (changeCallback) {
    options.callbacks.change = function(value) {
      updateModel.call(this, value);
      changeCallback.call(this, value);
    };
  }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants