Open
Conversation
CI Build PlanChanged FilesFortran source (1 file)
Python source (4 files)
Tests (1 file)
Documentation (6 files)
Build Configuration
Rationale
Updated by CI on each push. See path-filters.yml for category definitions. |
Author
|
Hi @dayantur Could you please review this change and help implement the appropriate validator logic? Based on my understanding, the validation rules should be:
Please let me know if this aligns with your understanding, or if any adjustments are needed. |
Preview Deployed
Note This preview is ephemeral. It will be lost when:
To restore, push any commit to this PR. |
…g for building material)
e7e9d3e to
ca47cc7
Compare
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates
RCmethodhandling in STEBBS and aligns the manual, schema/data model, and validator behavior with the intended logic.Main changes
rcmethod = 0now uses the intended default values:WallOuterCapFrac = 0.5RoofOuterCapFrac = 0.5rcmethod = 1now requires user-providedWallOuterCapFracandRoofOuterCapFracvalues, and validates that they are within the valid range (0-1).rcmethod = 2now adds validator checks and warnings for the required external wall/roof material properties external to insulation layer used for parameterisation.Documentation and validation updates
RCmethod,WallOuterCapFrac, andRoofOuterCapFrac.RCmethodrules.