Fix interpolation bounds error in RSL profiles (GH#1223)#1228
Open
Fix interpolation bounds error in RSL profiles (GH#1223)#1228
Conversation
Add defensive checks to prevent NaN/invalid values in MOST height generation: - Validate z_x and height array for NaN before interpolation - Clamp PAI to [0,1] and protect division by zero in resistance module - Fall back to input z0m_in/zdm_in when computed values are invalid - Ensure minimum height above roughness sublayer for degenerate cases Includes regression test for full-building urban grids.
CI Build PlanChanged FilesFortran source (2 files)
Rust bridge (1 file)
Tests (1 file)
Build Configuration
Rationale
Updated by CI on each push. See path-filters.yml for category definitions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1223
Adds defensive checks to prevent NaN and invalid values in MOST height generation: