Fix GH50: Separate infiltration from lateral water redistribution#1234
Draft
Fix GH50: Separate infiltration from lateral water redistribution#1234
Conversation
Physically separates infiltration (vertical water entry into soil) from lateral redistribution (horizontal water flow between land cover types). Infiltration now happens automatically based on soil capacity before redistribution, rather than being gated by the ToSoilStore parameter. - Add automatic infiltration step in suews_ctrl_driver.f95 before ReDistributeWater, capacity-limited for pervious surfaces only - Remove manual soil store accumulation from suews_phys_waterdist.f95 - Rename ToSoilStore to ToRunoff in WithinGridWaterDist matrix - Update Python data model, YAML converter, docs, sample files Closes #50 Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ToSoilStoreparameterToSoilStoretoToRunoffinWithinGridWaterDistto clarify it controls runoff partitioning of post-infiltration drainageChanges
suews_ctrl_driver.f95beforeReDistributeWater, capacity-limited for pervious surfaces onlysuews_phys_waterdist.f95ToSoilStorecolumn toToRunoffinWithinGridWaterDistmatrix and sample filesWaterDistribution), YAML converter (legacy compatibility), and documentationto_soilstorevalues are automatically migrated toto_runoffvia model validatorTest plan
make test)Closes #50
🤖 Generated with Claude Code