Move all state variables into environment within package#43
Merged
atharvashahane28 merged 20 commits intomainfrom Sep 26, 2025
Merged
Move all state variables into environment within package#43atharvashahane28 merged 20 commits intomainfrom
atharvashahane28 merged 20 commits intomainfrom
Conversation
…get_s3_config to config environment
…t, set, helper functions
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will:
configenvironment and assign default values to it.globals.Rtoconfigby adding a prefixconfig$when assigning and retrieving them. If there's any chance it would change in a different deployment it should be inconfigand not defined as a global constant in the package.set_s3_configand retrieved byget_s3_configto theconfigenvironment. Replaceassign()withconfig$option <-.local_temp_pathlog_file_path,log(flag to turn logging on and off)log_file_pathandloglocal_temp_paths3_config.R(fromflow.R)config$...