Refactor: UEFI forbidden for 32 bits VMs #2277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not allowed from the frontend but it spits and error just in case
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enforces the restriction that UEFI firmware is only supported for 64-bit virtual machines, preventing its use with 32-bit architectures.
Changes:
- Test filtering to skip UEFI tests for non-q35 machine types
- Architecture validation in UEFI configuration to restrict to x86_64 only
- Addition of helper method to locate appropriate machine types
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| t/vm/d20_disks.t | Adds test filter to skip UEFI+non-q35 machine combinations in CD-ROM tests |
| lib/Ravada/VM/KVM.pm | Restricts UEFI to x86_64 architecture, auto-selects q35 machine type when needed, and adds _find_machine_type helper method |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| $ovmf = '/usr/share/OVMF/OVMF_CODE_4M.fd'; | ||
| } else { | ||
| die "Unsupported UEFI in this architecture ".$type->toString(); |
There was a problem hiding this comment.
The error message uses toString() on the XML type element, which will produce verbose XML output. Consider using getAttribute('arch') instead to provide a clearer, more concise error message that only shows the architecture name.
Suggested change
| die "Unsupported UEFI in this architecture ".$type->toString(); | |
| die "Unsupported UEFI in this architecture ".$arch; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.