Skip to content

ci: simplify runner selection #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FlandiaYingman merged 1 commit into from
Feb 19, 2026
Merged

ci: simplify runner selection #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 5 additions & 32 deletions .github/workflows/check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,32 +23,10 @@ permissions:
pull-requests: read

jobs:
detect-quota:
# Probe the hosted runner (same flavor as the original try job) so we
# can decide whether to use a hosted runner or fall back to
# self-hosted. The job should fail if quota is exhausted.
permissions: {}
runs-on: ubuntu-slim
timeout-minutes: 1
steps:
- name: Quota probe
id: quota_probe
run: |
echo "probe"

# NOTE: Do not set `continue-on-error: true` on the `detect-quota` job.
# If `continue-on-error` is enabled the job result will always be
# 'success', which defeats detection (we rely on `needs.detect-quota.result`).
# Unfortunately this means the workflow may be reported as failed if the
# hosted runner is unavailable. We cannot work around this until GitHub
# provides a job-level "allow-failure"/neutral-conclusion feature
# (see: https://github.com/actions/runner/issues/2347 for discussion).
# `vars.ACTIONS_RUNNER_TYPE` is set on private repositories only.

lint-fmt:
# ESLint job inlined from check-shared-steps.yml
needs: detect-quota
if: ${{ always() }}
runs-on: ${{ needs.detect-quota.result == 'success' && 'ubuntu-slim' || 'self-hosted' }}
runs-on: ${{ vars.ACTIONS_RUNNER_TYPE || 'ubuntu-latest' }}
timeout-minutes: 5
continue-on-error: true
steps:
Expand Down Expand Up @@ -76,10 +54,8 @@ jobs:
yarn fmt:check

commitlint:
# Commitlint job inlined from check-shared-steps.yml
needs: detect-quota
if: ${{ always() && github.event_name == 'push' && github.ref == 'refs/heads/main' }}
runs-on: ${{ needs.detect-quota.result == 'success' && 'ubuntu-latest' || 'self-hosted' }}
if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/main' }}
runs-on: ${{ vars.ACTIONS_RUNNER_TYPE || 'ubuntu-latest' }}
timeout-minutes: 2
continue-on-error: true
steps:
Expand All @@ -88,10 +64,7 @@ jobs:
- uses: wagoid/commitlint-github-action@v6

tests:
# Tests job inlined from check-shared-steps.yml
needs: detect-quota
if: ${{ always() }}
runs-on: ${{ needs.detect-quota.result == 'success' && 'ubuntu-latest' || 'self-hosted' }}
runs-on: ${{ vars.ACTIONS_RUNNER_TYPE || 'ubuntu-latest' }}
timeout-minutes: 5
continue-on-error: true
steps:
Expand Down
25 changes: 2 additions & 23 deletions .github/workflows/docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,31 +28,10 @@ env:
IMAGE_NAME: ${{ github.repository }}

jobs:
detect-quota:
# Probe the hosted runner to decide whether to use hosted runners or
# fall back to self-hosted. Use the same runner flavor as the original
# try job.
permissions: {}
runs-on: ubuntu-slim
timeout-minutes: 1
steps:
- name: Quota probe
id: quota_probe
run: |
echo "probe"

# NOTE: Do not set `continue-on-error: true` on the `detect-quota` job.
# If `continue-on-error` is enabled the job result will always be
# 'success', which defeats detection (we rely on `needs.detect-quota.result`).
# Unfortunately this means the workflow may be reported as failed if the
# hosted runner is unavailable. We cannot work around this until GitHub
# provides a job-level "allow-failure"/neutral-conclusion feature
# (see: https://github.com/actions/runner/issues/2347 for discussion).
# `vars.ACTIONS_RUNNER_TYPE` is set on private repositories only.

docker:
needs: detect-quota
if: ${{ always() }}
runs-on: ${{ needs.detect-quota.result == 'success' && 'ubuntu-latest' || 'self-hosted' }}
runs-on: ${{ vars.ACTIONS_RUNNER_TYPE || 'ubuntu-latest' }}
timeout-minutes: 5
continue-on-error: true
steps:
Expand Down
24 changes: 2 additions & 22 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,30 +19,10 @@ env:
IMAGE_NAME: ${{ github.repository }}

jobs:
detect-quota:
# Probe the hosted runner flavor used by release steps so we can fall
# back if necessary.
permissions: {}
runs-on: ubuntu-slim
timeout-minutes: 1
steps:
- name: Quota probe
id: quota_probe
run: |
echo "probe"

# NOTE: Do not set `continue-on-error: true` on the `detect-quota` job.
# If `continue-on-error` is enabled the job result will always be
# 'success', which defeats detection (we rely on `needs.detect-quota.result`).
# Unfortunately this means the workflow may be reported as failed if the
# hosted runner is unavailable. We cannot work around this until GitHub
# provides a job-level "allow-failure"/neutral-conclusion feature
# (see: https://github.com/actions/runner/issues/2347 for discussion).
# `vars.ACTIONS_RUNNER_TYPE` is set on private repositories only.

release_please:
needs: detect-quota
if: ${{ always() }}
runs-on: ${{ needs.detect-quota.result == 'success' && 'ubuntu-latest' || 'self-hosted' }}
runs-on: ${{ vars.ACTIONS_RUNNER_TYPE || 'ubuntu-latest' }}
timeout-minutes: 5
continue-on-error: true

Expand Down