Skip to content

Conversation

@lllumineux
Copy link

  • add node_modules & local_config.py to .gitignore
  • replace example_config.py to the main folder and delete the folder named "infolesson"

@lllumineux lllumineux requested a review from BardRandall August 28, 2019 17:02
@lllumineux
Copy link
Author

rip to travis ci

@lllumineux lllumineux self-assigned this Aug 28, 2019
node_modules/

# Config files
local_config.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file already exists in gitignore, look at the last line of the file


# IDE files
.idea/
node_modules/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think node_modules is IDE files, pls add some cool comment

@BardRandall
Copy link
Member

Also pls leave example_config.py file in folder infolesson, because all executable files will be there. Outside you can see just some files, that not directly belongs to project.

@lllumineux
Copy link
Author

lllumineux commented Aug 28, 2019 via email

@BardRandall
Copy link
Member

Pls look at structure of this project: https://github.com/summer-school-2019/money-bot.
You local_config.py is ready to be commited because in .gitignore file it's marked as infolesson/local_config.py.example_config.py already in infolesson folder, so you just need to copy it in the same folder.
infolesson folder I need to run my project properly. I just should type python -m infolesson, and it's OK. I don't want to type python -m src.
I don't understand what is dist folder.
As you can see, all project files are in the infolesson folder, but .gitignore, .travis.yml, .venv folder, (Dockerfile in future) are not directly belongs to project, they just us to support and develop it. So, just imagine that infolesson is root directory for your project.

@lllumineux
Copy link
Author

This is a bot project, and we are creating a web-site! It's incorrect to compare them! Let's have a discussion about project structure in discord.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants