Fix ExportSkeleton USDZ scale#184
Open
hybridherbst wants to merge 1 commit intoUnity-Technologies:devfrom
Open
Fix ExportSkeleton USDZ scale#184hybridherbst wants to merge 1 commit intoUnity-Technologies:devfrom
hybridherbst wants to merge 1 commit intoUnity-Technologies:devfrom
Conversation
jcowles
approved these changes
Jul 3, 2020
Contributor
jcowles
left a comment
jcowles
left a comment
There was a problem hiding this comment.
Looks good, thanks for the fix!
| var oldParent = objContext.gameObject.transform.parent; | ||
| objContext.gameObject.transform.SetParent(null, worldPositionStays: false); | ||
| var originalScale = objContext.gameObject.transform.localScale; | ||
| objContext.gameObject.transform.localScale *= 1 / exportContext.scale; |
Contributor
There was a problem hiding this comment.
I do believe this was intended to be captured by SetParent(null, ...) above, it's just that the scale wasn't captured.
Contributor
There was a problem hiding this comment.
I guess my remaining question is if this should be 1/exportContext.scale or if it should just be 1.
jcowles
suggested changes
Jul 3, 2020
Contributor
jcowles
left a comment
jcowles
left a comment
There was a problem hiding this comment.
After some local testing, this only seems right in some scenarios... I'm digging in a bit more to better understand what's going on between the bbox and geometry scales
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After adding scale in ExportContext bounds were now broken for animated meshes. I'm still not 100% sure about this, but at least the order of magnitude of the bounds is correct again (and exports look right in usdview which they don't without this PR).