Open
Conversation
joeyskeys
force-pushed
the
light_schema
branch
from
9b1b34e to
3044d72
Compare
joeyskeys
force-pushed
the
light_schema
branch
from
3044d72 to
08f95cd
Compare
joeyskeys
force-pushed
the
light_schema
branch
from
5069375 to
3af5bcb
Compare
Author
|
There's a problem I dunno how to fix now: |
|
How to export/import light color? |
Author
Seems I didn't add this property |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Ticket/Jira #:
This's a draft PR that I'm still working on, would like to get some feedback.
This PR adds light import from usd files.
Currently supports point, directional, rect light import.
Spotlight is exported in a special way and could be supported too, working on it now.
Testing
Functional Testing status:
I've tested point & directional light import, lights were imported at the right place, but some attributes are not correctly imported, the usd maya plug didn't write out many attributes.
Performance Testing status:
Light types are different schemas defined in USD.
Currently, I use 4 loops to iterate through each light type in the USD file and import them.
Should make no big impact on the performance.
Overall Product Risks
Complexity:
Low
Halo Effect:
Low
Additional information
Note to reviewers:
I need some suggestions to finish up this PR.
Reminder:
Still a draft PR, please leave message if you have any ideas.