Conversation
lee-aandrew
force-pushed
the
add-test-InitUsd
branch
from
0e16236 to
33342e6
Compare
vickycl
left a comment
vickycl
left a comment
There was a problem hiding this comment.
I think we need to rethink how to thoroughly test the InitUSD.Initialize test without it impacting/ being impacted by the other tests having the plugin initialised. Perhaps we could make a fake instance (not sure how it would interact with the real instance though) or maybe we need a test outside of UTR...
| } | ||
|
|
||
| [Test] | ||
| public void InitUsd_Initialize() |
There was a problem hiding this comment.
Please add the expected result to the end of the test name, something like "InitUsd_Initialize_Succeeds"
| // Reset 'm_usdInitialized' for accurate testing | ||
| ResetInitUsd(); | ||
|
|
||
| Assert.True(InitUsd.Initialize(), "USD Initialize failed"); |
There was a problem hiding this comment.
Is there a more robust thing we can also check for, as well as the return value of Initialise()?
There was a problem hiding this comment.
eg check that the plugin is registered, that the expected debug log is printed, that no other errors are handled and logged.
There was a problem hiding this comment.
i've looked into this a bit more - on how to tell if the plugin has been registered and the typebinding
But I just ended up having more questions, do you know who I should be asking about the init steps?
There was a problem hiding this comment.
You can check that unity types have been added the TypeBinder, that usd error message are logged in Unity console and that the plugins Registry is not empty. We can chat if you have more questions.
There was a problem hiding this comment.
Thank you @judubu - I will contact you via slack!
There was a problem hiding this comment.
After talking with Julien, it turns out the PlugRegistry is not behaving correctly - created a separate JIRA ticket for this
https://jira.unity3d.com/browse/USDU-295
Will continue work on this PR after the above JIRA ticket has been solved
| public void InitUsd_Initialize() | ||
| { | ||
| // Reset 'm_usdInitialized' for accurate testing | ||
| ResetInitUsd(); |
There was a problem hiding this comment.
I'm not sure that just changing the bool is enough here. Initialize() does stuff that might affect this test, such as setting up the UnityTypeBindings for USD. I'm not sure what the answer is though :D
4 participants
Purpose of this PR
USDU-249
Testing
Adds test cases for InitUsd script
tries to check if an early throw / exit is done when given wrong parameter value for function InitUsd.SetupUsdPath()
Complexity:
1
Halo Effect:
1