[TCPServer] Close all filedescriptors on shutdown#432
Merged
urfeex merged 3 commits intoUniversalRobots:masterfrom Feb 11, 2026
Merged
[TCPServer] Close all filedescriptors on shutdown#432urfeex merged 3 commits intoUniversalRobots:masterfrom
urfeex merged 3 commits intoUniversalRobots:masterfrom
Conversation
A connected client should be aware that the server went away of the server object is destroyed.
This fixes a bug where clients would not have been aware that the server went away, as we just closed the listen filedescriptor, but not the one attached to a client.
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on February 20. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #432 +/- ##
==========================================
- Coverage 74.35% 74.11% -0.24%
==========================================
Files 103 103
Lines 5131 5134 +3
Branches 544 545 +1
==========================================
- Hits 3815 3805 -10
- Misses 1033 1048 +15
+ Partials 283 281 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The timeout of 100ms was a bit optimistic depending on the system that we run on. Since it's only the worst-case scenario, so the test will only take that much time if it actually fails, having this quite high should be alright.
urrsk
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug where clients would not have been aware that the server
went away, as we just closed the listen filedescriptor, but not the one
attached to a client.