pcap #1096
Open
pcap #1096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kierank
reviewed
Sep 4, 2025
Collaborator
|
Could you rebase and solve conflicts with the build system so we can merge? |
nto
requested changes
Jan 15, 2026
Collaborator
nto
left a comment
nto
left a comment
There was a problem hiding this comment.
A wrapper for an external library should be a standalone module, not included in upipe-modules.
Contributor
Author
|
Please check examples/Build.mk pcap-deps pcap-deps = upipe_pcap_src doesn't work as I thought it would |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Source using pcap files