fix: proposaltablereviewer call and instrument filters

[TCMeldrum]

Closes UserOfficeProject/issue-tracker#1498

Description

This PR enhances the functionality of proposal review by ensuring that reviewers only see calls and instruments that are relevant to their assigned reviews.

I have added new endpoint for these as I could not find a easy way of intergrating it into the current methods.

Motivation and Context

This change is required to streamline the review process and make it more efficient. It solves the problem of reviewers having to sift through irrelevant calls and instruments not assigned to their FAP.

Changes

• Added methods to retrieve calls and instruments based on FAP IDs in the CallDataSource and InstrumentDataSource interfaces.
• Implemented these methods in the corresponding data sources.
• Updated queries in CallQueries and InstrumentQueries to utilize these new methods.
• Updated resolvers to use the updated queries.
• Updated frontend to use the new queries and display relevant data to reviewers.

Please note that these changes have been tested and verified to work as expected.

How Has This Been Tested?

Fixes Jira Issue

https://jira.esss.lu.se/browse/

Depends On

Tests included/Docs Updated?

• I have added tests to cover my changes.
• All relevant doc has been updated

[Scott-James-Hurley]

I gave this a whirl but it doesn't seem like all the instruments in the table appear on the filter. I added myself as a reviewer to FAP 11 and then assigned myself some proposals. It looks like on dev FAP 11 only has Ines assigned to it. I guess this is just an issue with the data on dev. Alternatively, you could get the instruments the user can filter from the proposals fetched for the table?

[TCMeldrum]

@Scott-James-Hurley Thanks for catching that, I have refacoted the db query to get instruments of any proposal that have been assigned to that fap

[Scott-James-Hurley]

Looks great. Worth noting that a similar thing with happens with the call filter but in practice I don't see how it would affect users. A reviewer wouldn't be assigned proposals from a closed call to review:

[yoganandaness]

@TCMeldrum I have given my comments.

But, this looks a bit related to multi facility feature. I could be wrong.

@jekabs-karklins If it is, do you think your PR 1282 could solve this and make this one redundant?

[TCMeldrum]

@TCMeldrum I have given my comments.

But, this looks a bit related to multi facility feature. I could be wrong.

@jekabs-karklins If it is, do you think your PR 1282 could solve this and make this one redundant?

This is just updating the fap reviews table to only show relivent calls as it shows all calls right now. It would be relevent as it could be different for 2 users in the same facility.