feat: swap 4949 workflow overhaul#1297
Conversation
…elated methods and types
…g and introducing WorkflowStatus model
…lowStatusId instead of id
…ntroducing CreateWorkflowConnection mutation
…rget status lookups
…vents table and updating related references
…usActionsOnConnection
…lowStructure method
…onsistency in workflow management
…efactoring IsProposalSubmittedGuard
…andling and refactoring related methods
…error for missing proposal workflow
… GuardFn and refactoring related guards
…ent metadata handling
…tatusConnectionId and refactor related properties
…authorization checks for proposal assignments
…orkflow migration scripts
… for proposal status filtering
…just status handling in tests
|
What is this PR actually trying to do? The body mentions "limitations and inefficiencies" but it seems so vague I have no idea, and I don't have access to the linked ESS jira item. If this is for the "allowing a status to be on a workflow multiple times" thing mentioned at sprint planning, I thought that was going to go to a discussion thread so we could figure out what the approach to take should be? And from a review standpoint, I don't see how I'm practically going to be able to review 10k lines of code changes. |
Hi @ACLay , All valid points, and I have therefore not marked this as review:please just yet. Side note: When started on this overhaul I did not realize that workflow touches so many things in the application, and this turned out the be the biggest PR I have made. Meanwhile I will try to improve the description of the PR to give high level overview. Thanks for the proactive comment |
…mproved management
…eters and remove unused fieldMap
…tInitialStatus' and 'getInitialWorkflowStatus' for consistency
…to private for encapsulation
… workflow structure
…ks in workflow handlers
…gleInput for better flexibility
… naming consistency
…mentSafety method
… structure in InstrumentMutations tests
…mproved readability
Description
This PR introduces new database structures to improve the workflow management system.
Motivation and Context
The current workflow management system has limitations and inefficiencies that are addressed by the introduction of new database structures. This change is required to enhance the system's performance and user experience.
Changes
How Has This Been Tested?
Fixes Jira Issue
https://jira.esss.lu.se/browse/SWAP-4949
Depends On
Tests included/Docs Updated?