Skip to content

feat: add review visibility feature to faps#1355

Open
TCMeldrum wants to merge 7 commits intodevelopfrom
1522-fap-reviewers-visibility
Open

feat: add review visibility feature to faps#1355
TCMeldrum wants to merge 7 commits intodevelopfrom
1522-fap-reviewers-visibility

Conversation

@TCMeldrum
Copy link
Contributor

@TCMeldrum TCMeldrum commented Feb 16, 2026

Closes UserOfficeProject/issue-tracker#1522

Description

This PR introduces the review visibility feature to faps.

Motivation and Context

This change is required to add more flexibility and control over the visibility of the reviews. It allows setting different stages when the reviews can be visible which enhances the review process.

Changes

  1. A new column 'review_visibility' is added to the 'faps' table in the database. This column will hold the review visibility status.
  2. The 'FapDataSource.ts' and 'FapDataSourceMock.ts' are updated to include 'review_visibility' in the 'Fap' model.
  3. The 'ProposalDataSource.ts' has been updated to include a new boolean column 'call_fap_review_ended' to track the end status of the 'fap' review for a proposal.

Finally, these changes have been reflected across the backend where the 'Fap' model is used.

How Has This Been Tested?

Introduces backend tests to cover the new review visiiblity setting

Fixes Jira Issue

https://jira.esss.lu.se/browse/

Depends On

Tests included/Docs Updated?

  • I have added tests to cover my changes.
  • All relevant doc has been updated

@TCMeldrum TCMeldrum requested a review from a team as a code owner February 16, 2026 14:15
@TCMeldrum TCMeldrum requested review from simonfernandes and removed request for a team February 16, 2026 14:15
) THEN

ALTER TABLE faps
ADD COLUMN IF NOT exists review_visibility text;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there's only a few different values this should have, I wonder if a separate table which faps has a foreign key reference to might be more suitable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have refactored it to do this. I think in terms of data it is better but in terms of reability of code it is as nice, I prefered seeing Fap objects with reviewVisibility: FapReviewVisibility.PROPOSAL_REVIEWS_COMPLETE rather than reviewVisibility: 1. I couldnt see a nice way around it tho

@jekabs-karklins jekabs-karklins self-requested a review February 18, 2026 13:27
@TCMeldrum TCMeldrum requested a review from ACLay February 18, 2026 16:19
Copy link
Contributor

@ACLay ACLay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree it's a shame we couldn't keep the API property as the enum, but I think this looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Faps should be able to configure when reviewers can see other reviewers reviews

2 participants