feat: add review visibility feature to faps#1355
Open
Conversation
ACLay
reviewed
Feb 17, 2026
| ) THEN | ||
|
|
||
| ALTER TABLE faps | ||
| ADD COLUMN IF NOT exists review_visibility text; |
Contributor
There was a problem hiding this comment.
If there's only a few different values this should have, I wonder if a separate table which faps has a foreign key reference to might be more suitable?
Contributor
Author
There was a problem hiding this comment.
I have refactored it to do this. I think in terms of data it is better but in terms of reability of code it is as nice, I prefered seeing Fap objects with reviewVisibility: FapReviewVisibility.PROPOSAL_REVIEWS_COMPLETE rather than reviewVisibility: 1. I couldnt see a nice way around it tho
ACLay
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes UserOfficeProject/issue-tracker#1522
Description
This PR introduces the review visibility feature to faps.
Motivation and Context
This change is required to add more flexibility and control over the visibility of the reviews. It allows setting different stages when the reviews can be visible which enhances the review process.
Changes
Finally, these changes have been reflected across the backend where the 'Fap' model is used.
How Has This Been Tested?
Introduces backend tests to cover the new review visiiblity setting
Fixes Jira Issue
https://jira.esss.lu.se/browse/
Depends On
Tests included/Docs Updated?