fix: add error notification for sample creation when no sample declaration was found in proposal template#1362
Open
jekabs-karklins wants to merge 3 commits intodevelopfrom
Conversation
…uestions are found
jekabs-karklins
requested review from
deepaksftc
and removed request for
a team
…emove-it-i-can-not
Contributor
Author
|
@deepaksftc I have marked this as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces an error notification for users when attempting to create a sample if no sample declaration was found in the proposal template.
Motivation and Context
This is not a main use case and should ideally never occur. However, if a proposal template is missing a sample declaration, we should handle it gracefully: instead of application throwing a generic error, we display a clear notification explaining that a sample can’t be created and advising the user to contact the User Office. This provides better feedback and reduces confusion in this edge case.
Changes
useSnackbarhook to display an error notification when no sample declaration is found.How Has This Been Tested?
Fixes Jira Issue
https://jira.esss.lu.se/browse/SWAP-1983