fix: remove surveyComment field from Call model and related components#1364
Open
jekabs-karklins wants to merge 4 commits intodevelopfrom
Open
fix: remove surveyComment field from Call model and related components#1364jekabs-karklins wants to merge 4 commits intodevelopfrom
jekabs-karklins wants to merge 4 commits intodevelopfrom
Conversation
jekabs-karklins
requested review from
deepaksftc
and removed request for
a team
Contributor
Author
|
@deepaksftc And could you also please check it at your earlies convenience :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes
surveyCommentfield from theCallmodel and all related components.Motivation and Context
The
surveyCommentfield was found to be redundant and is not being used anywhere in the application besides the form where it is defined.Changes
surveyCommentcolumn fromcalltable in the database.surveyCommentfield fromCallmodel and mock data sources.surveyCommentfield usage from all related components and tests.Fixes Jira Issue
https://jira.esss.lu.se/browse/SWAP-5283
Depends On
Tests included/Docs Updated?