feat: only show calls that are related to techniques assigned to an instrument scientist#1370
Open
mutambaraf wants to merge 10 commits intodevelopfrom
Open
feat: only show calls that are related to techniques assigned to an instrument scientist#1370mutambaraf wants to merge 10 commits intodevelopfrom
mutambaraf wants to merge 10 commits intodevelopfrom
Conversation
mutambaraf
changed the title
mutambaraf
requested review from
a team,
bolmsten and
simonfernandes
and removed request for
a team
Contributor
There was a problem hiding this comment.
I think we want to keep the call.id so that it defaults on the open call of that year
mutambaraf
commented
Feb 25, 2026
| const lastProcessedCallId = useRef<number | null>(null); | ||
| useEffect(() => { | ||
| if (calls && calls.length > 0 && !searchParams.get('call')) { | ||
| const activeCall = calls.find((call) => call.isActive); |
Contributor
Author
There was a problem hiding this comment.
@ellen-wright .Yes we are still setting it, but I am setting it here inside the table because if I set it higher up, the set ID might technically not be part of the call the user has access to.
Contributor
There was a problem hiding this comment.
I am currently dealing with this issue in this PR #1357 so might be worth us trying to coordinate this
Contributor
Author
There was a problem hiding this comment.
Will wait for your PR as discussed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the filtering of calls related to techniques assigned to an instrument scientist.
Closes: UserOfficeProject/issue-tracker#1518
Motivation and Context
Currently, the Xpress Management page displays all calls with a QUICK_REVIEW status. This PR introduces changes that allow filtering calls based on assigned techniques. Additionally, the "All" filter has been updated to return only proposals with calls relevant to those filters. This ensures instrument scientists only see proposals related to their specific facility and assigned techniques.
Changes
callIdsarray in addition to thecallIdfield.PostgresProposalDataSourceandStfcProposalDataSourceclasses in the backend, and reflected in the frontend in theProposalsQueryclass and theMenuItemsandProposalMenuListItemcomponents.callIdsfield is added to theProposalsFilterclass.techniqueProposalUrlis now set to/TechniqueProposalsinstead of being dependent on theopenCall.id.These changes ensure that only the calls related to techniques assigned to the instrument scientist are displayed, improving the relevance of the displayed data for the user.
How Has This Been Tested?
Fixes Jira Issue
https://jira.esss.lu.se/browse/
Depends On
Tests included/Docs Updated?