Add pull request trigger for npm publish workflow#227
Closed
jekabs-karklins wants to merge 1 commit intomasterfrom
Closed
Add pull request trigger for npm publish workflow#227jekabs-karklins wants to merge 1 commit intomasterfrom
jekabs-karklins wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Two branches often need simultaneous updates to duo-validation. Previously, to get the end-to-end tests passing in user-office-core, we had to merge the validation changes into master just to trigger a new npm package publish. That forced us to land validation updates before the dependent user-office-core code was ready. Once one branch merged, the other branch immediately hit conflicts in duo-validation, slowing everyone down.
Change
This PR updates the npm publish workflow to run not only on master, but also whenever a PR targeting master is opened or updated. That way we can build and publish pre-release packages straight from the PR branch.
Result
We can keep the validation changes on their feature branches until their matching user-office-core PRs are merged. Each branch gets its own npm package built from the PR, so user-office-core E2E jobs can install and test against the right validation code without forcing premature merges.