Skip to content

Code minification #734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ExactlyNoSense wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Code minification #734

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a4e3c13
Add optimize setting into build config `minify` to enable/disable cod…
ExactlyNoSense Aug 4, 2022
e0243e7
Use build config minify setting in webpack optimization
ExactlyNoSense Aug 4, 2022
5a19b18
:memo: CHANGELOG
ExactlyNoSense Aug 4, 2022
66b7318
Changed flag to 'debug-mode' that change not only minimize setting
ExactlyNoSense Aug 16, 2022
54d216f
:memo: CHANGELOG
ExactlyNoSense Aug 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,13 @@ Changelog

_Note: Gaps between patch versions are faulty, broken or test releases._

## v3.??.?? (2022-08-??)

#### :rocket: New Feature

* Added new property `debugMode` to `build` object `config/default`
Copy link
Contributor

@kobezzza kobezzza Aug 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Added new property `debugMode` to `build` object `config/default`
* Added a new property `build.debugMode` `config/default`

* Added ability to disable code optimizations for debug mode `build/webpack/optimization`
Copy link
Contributor

@kobezzza kobezzza Aug 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Added ability to disable code optimizations for debug mode `build/webpack/optimization`
* Debugging mode now disables code minimization `build/webpack/optimization`


## v3.??.? (2022-??-??)

#### :house: Internal
Expand Down
6 changes: 6 additions & 0 deletions build/webpack/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,12 @@ Changelog
> - :house: [Internal]
> - :nail_care: [Polish]

## v3.??.?? (2022-08-??)

#### :rocket: New Feature

* Added ability to disable code optimizations for debug mode `build/webpack/optimization`
Copy link
Contributor

@kobezzza kobezzza Aug 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Added ability to disable code optimizations for debug mode `build/webpack/optimization`
* Debugging mode now disables code minimization


## v3.24.0 (2022-08-12)

#### :rocket: New Feature
Expand Down
7 changes: 7 additions & 0 deletions build/webpack/optimization.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,5 +107,12 @@ module.exports = function optimization({buildId, plugins}) {
/* eslint-enable camelcase */
];

if (config.build.debugMode) {
Copy link
Contributor

@kobezzza kobezzza Aug 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А оно только JS не сжимает, или CSS тоже?

По хорошему надо бы оставить все.

opts.minimize = false;
opts.chunkIds = 'named';
opts.moduleIds = 'named';
opts.mangleExports = false;
}

return opts;
};
6 changes: 6 additions & 0 deletions config/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,12 @@ Changelog
> - :house: [Internal]
> - :nail_care: [Polish]

## v3.??.?? (2022-08-??)

#### :rocket: New Feature

* Added new property `debugMode` to `build` object
Copy link
Contributor

@kobezzza kobezzza Aug 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Added new property `debugMode` to `build` object
* Added a new property `build.debugMode`


## v3.20.0 (2022-04-25)

#### :boom: Breaking Change
Expand Down
13 changes: 13 additions & 0 deletions config/default.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,6 +304,19 @@ module.exports = config.createConfig({dirs: [__dirname, 'client']}, {
suit: o('suit', {
env: true,
default: 'demo'
}),

/**
* If true, all code optimizations will be disabled which is suitable for application debugging
*
* @cli debug-mode
* @env DEBUG_MODE
*
* @returns {boolean}
*/
debugMode: o('debug-mode', {
Copy link
Contributor

@kobezzza kobezzza Aug 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Мне кажется просто debug лучше назвать, т.к. оно и так понятно, что это режим.

Плюс у нас есть в настройках есть

/** @override */
	runtime() {
		return {
			...super.runtime(),
			engine: this.engine(),

			debug: false,

И тут бы прораститить тот дебаг в этот.

Copy link
Contributor Author

@ExactlyNoSense ExactlyNoSense Aug 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

debug из рантайма попадает в конфиг моника, а также в глобальные константы. Не получится ли так, что кто-то с этим дебагом (из runtime) подвяжется на изменение отображения или подключение других зависимостей. А я всего-лишь хочу, чтобы всё, что было в проде, просто собралось чуть подубонее для дебага.

Можно сделать как-то так: добавить параметр/переменную окружения debug-build, которая будет делать то, что сейчас debug-mode, а ещё сделать параметр/переменную окружения debug, которая будет включать debug-build а так же проставлять debug в runtime.

Т.е. можно будет либо включать весь дебаг везде сразу, либо более точно изменять только сборку проекта. Что скажешь?

Copy link
Contributor

@kobezzza kobezzza Aug 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ну в принципе да, можно сделать в конфиге

build.debug -- параметр debug-build

и debug в корне, который включает build.debug и runtime.debug

env: true,
type: 'boolean'
})
},

Expand Down