Implement container for the inspected application and components#15
Open
shining-mind wants to merge 12 commits intomainfrom
Open
Implement container for the inspected application and components#15shining-mind wants to merge 12 commits intomainfrom
shining-mind wants to merge 12 commits intomainfrom
Conversation
This class is similar to JSHandle in Playwright
This is a special handle to interact with the component on the page
ItMaga
reviewed
May 6, 2024
packages/devtools-core/src/core/inspect/component-handle/class.ts
Outdated
Show resolved
Hide resolved
Comment on lines
+151
to
+152
| // eslint-disable-next-line @typescript-eslint/no-floating-promises | ||
| ctx.setMod(name, value); |
Member
There was a problem hiding this comment.
А не странно, что у нас engines/loopback-engine.ts, который экспортирует evaluateEngine и disposeEngine? Как будто движки в движке, может сделать просто engines/loopback.ts?
| import { devtoolsEval } from 'core/browser-api'; | ||
| import type { DisposeEngine, EvaluateEngine } from 'core/inspect/devtools-handle/interface'; | ||
|
|
||
| // eslint-disable-next-line @v4fire/require-jsdoc |
Member
There was a problem hiding this comment.
Может тут добавить ссылку на DevtoolsHandle.evaluate? Чтобы было более очевидно, что именно переопределяем в слое
| TreeItem[] children | ||
| } | ||
|
|
||
| class InspectedApp { |
Member
There was a problem hiding this comment.
А подскажи, пожалуйста, я правильно понимаю, что этот класс будет отвечать за общение между бэкендом и конечным клиентом?
Contributor
Author
There was a problem hiding this comment.
Да, задумка была такая: сделать абстракцию над исследуемым приложением, по аналогии как Page в Playwright.
Co-authored-by: Magomed Chemurziev <m-chemurziev@ya.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.