Skip to content

Dynamic bsg_fakeram#3

Open
paolopedroso wants to merge 10 commits intomasterfrom
dynamic
Open

Dynamic bsg_fakeram#3
paolopedroso wants to merge 10 commits intomasterfrom
dynamic

Conversation

@paolopedroso
Copy link

No description provided.

@bgoldbug bgoldbug self-requested a review August 25, 2025 22:20
Copy link

@bgoldbug bgoldbug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall great work on the additions to the repo! A few suggestions:

  • We should display the custom stuff in it's own config (something like customTech.cfg).
    • This can showcase parameters like dh_read and pinPitchFactor. Things that aren't necessary for generating a basic config.
  • Add a README for each subdir that you have, briefly explaining what each file does.
    • It might even be worthwhile to add a README to the example_cfgs/ which describes the custom parameters that can be added. (maybe even change folders name to default_cfgs)

While most of this stuff is just suggestive so that the default (non-custom) configs can be more readable, the REQUIRED change is that pinHeight and pinWidth need to be respective to each layer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants