Open
Conversation
bgoldbug
requested changes
Aug 27, 2025
bgoldbug
left a comment
There was a problem hiding this comment.
Overall great work on the additions to the repo! A few suggestions:
- We should display the custom stuff in it's own config (something like customTech.cfg).
- This can showcase parameters like
dh_readandpinPitchFactor. Things that aren't necessary for generating a basic config.
- This can showcase parameters like
- Add a README for each subdir that you have, briefly explaining what each file does.
- It might even be worthwhile to add a README to the example_cfgs/ which describes the custom parameters that can be added. (maybe even change folders name to default_cfgs)
While most of this stuff is just suggestive so that the default (non-custom) configs can be more readable, the REQUIRED change is that pinHeight and pinWidth need to be respective to each layer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.